Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support promises API in patchFs #217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aleung
Copy link

@aleung aleung commented Feb 9, 2021

@aleung aleung mentioned this pull request Feb 9, 2021
@aleung
Copy link
Author

aleung commented Apr 21, 2021

@streamich Would you review this PR?

@G-Rath
Copy link
Collaborator

G-Rath commented Jun 2, 2023

@aleung sorry for the delay - is there a reason why you've used Object.defineProperty instead of just assigning like we do with other methods?

@aleung
Copy link
Author

aleung commented Jun 8, 2023

It was a long time since I wrote the code. I can't exactly remember the reason.

I think I don't want promises to be a normal property of the object:

By default, properties added using Object.defineProperty() are not writable, not enumerable, and not configurable.

More explanation is in https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty#description

@sladg
Copy link

sladg commented Nov 20, 2023

Hey there! Is there a reason this is not merged by now? :) I'm looking forward to use the library, however, this is a dealbreaker as I need to patch promise calls to FS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Promises
3 participants